<html>
<head><meta charset="utf-8"><title>status update 2020-10-30 · t-compiler/wg-rfc-2229 · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/index.html">t-compiler/wg-rfc-2229</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/status.20update.202020-10-30.html">status update 2020-10-30</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="218339841"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/status%20update%202020-10-30/near/218339841" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aman Arora <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/status.20update.202020-10-30.html#218339841">(Nov 30 2020 at 20:17)</a>:</h4>
<p>So we didn't meet last week and I kind of left a bunch of messages, here is the condensed form</p>
<ul>
<li>We have a somewhat working thing (<a href="https://github.com/rust-lang/rust/pull/79553">https://github.com/rust-lang/rust/pull/79553</a>)</li>
<li>Major know issues:<br>
    - Mutability of capture comes from a mut ref, check <a href="#narrow/stream/189812-t-compiler.2Fwg-rfc-2229/topic/mutability.20of.20captured.20path/near/218188362">thread for examples</a><br>
    - Wild card in patterns</li>
<li><a href="https://perf.rust-lang.org/compare.html?start=28b86e0860f0593b85cda6c2c7b03ae8a582962f&amp;end=f76f72250e36c9ad4eb3bd3f08770228cc07da6c">Perf results</a> for when feature gate insn't enabled: Discussed on <a class="stream" data-stream-id="247081" href="/#narrow/stream/247081-t-compiler.2Fperformance">#t-compiler/performance</a>  and was told that 4% on incr might not be something to worry about</li>
<li>Borrow checker prints precise path on its own, though we need to work on still presenting the information better. Chris has spent some time working on storing spans for capture kind and capture path separately. (<a href="https://github.com/rust-lang/project-rfc-2229/issues/22">https://github.com/rust-lang/project-rfc-2229/issues/22</a>)</li>
<li>Jenny and Logan are working on cleaning up last remaining usages of closure_captures and upvar_capture_map (the old data structures)</li>
</ul>
<p><span class="user-mention" data-user-id="116009">@nikomatsakis</span></p>



<a name="218340023"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/status%20update%202020-10-30/near/218340023" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aman Arora <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/status.20update.202020-10-30.html#218340023">(Nov 30 2020 at 20:19)</a>:</h4>
<p>Also do we want to merge the PR as it stands? Since it doesn't affect code that doesn't use the feature but allow us to create PRs specific for bug fixes</p>



<a name="218352373"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/status%20update%202020-10-30/near/218352373" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/status.20update.202020-10-30.html#218352373">(Nov 30 2020 at 22:01)</a>:</h4>
<p><span class="user-mention" data-user-id="281950">@Aman Arora</span> I have no problem merging incomplete code as long as it's feature gated</p>



<a name="218352503"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/status%20update%202020-10-30/near/218352503" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aman Arora <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/status.20update.202020-10-30.html#218352503">(Nov 30 2020 at 22:02)</a>:</h4>
<p>I think that PR is then mostly read for review, I'll just remove tests that don't work (run pass pattern tests). I had disabled them for perf test</p>



<a name="218352537"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/status%20update%202020-10-30/near/218352537" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/status.20update.202020-10-30.html#218352537">(Nov 30 2020 at 22:02)</a>:</h4>
<p>can you r? me on it then</p>



<a name="218352547"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/status%20update%202020-10-30/near/218352547" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/status.20update.202020-10-30.html#218352547">(Nov 30 2020 at 22:02)</a>:</h4>
<p>or I can</p>



<a name="218352625"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/status%20update%202020-10-30/near/218352625" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aman Arora <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/status.20update.202020-10-30.html#218352625">(Nov 30 2020 at 22:03)</a>:</h4>
<p>I'd recommend commit-commit review, I tried to keep them as separate as possible this time <span aria-label="sweat smile" class="emoji emoji-1f605" role="img" title="sweat smile">:sweat_smile:</span></p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>